Skip to content

Remove exec permissions from all test files and add CI check to enforce moving forward - #322

Merged
mike-hunhoff merged 4 commits into
masterfrom
fix/perms
Aug 11, 2026
Merged

Remove exec permissions from all test files and add CI check to enforce moving forward#322
mike-hunhoff merged 4 commits into
masterfrom
fix/perms

Conversation

@mike-hunhoff

Copy link
Copy Markdown
Collaborator

We should not be storing test files with exec permissions. This PR removes exec permissions and adds a CI check to enforce this moving forward.

@mike-hunhoff
mike-hunhoff requested review from a team and williballenthin August 10, 2026 20:01

@williballenthin williballenthin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@mike-hunhoff

Copy link
Copy Markdown
Collaborator Author

See mandiant/capa#3141 for details on why the runtime checks are failing. I'm opting to merge this pull request without fixing due to lack of cycles and priority to fully address #3141 at this time.

@mike-hunhoff
mike-hunhoff merged commit f8ad3cb into master Aug 11, 2026
9 of 10 checks passed
@mr-tz
mr-tz deleted the fix/perms branch August 11, 2026 18:32
@mr-tz

mr-tz commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

yes thats fair, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants